lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #7855] Provide alternative timeout implementation


From: chrysn
Subject: [lwip-devel] [patch #7855] Provide alternative timeout implementation
Date: Thu, 21 Nov 2013 09:26:09 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/538.1 (KHTML, like Gecko) Chromium/25.0.1349.2 Chrome/25.0.1349.2 Safari/538.1 Debian/unstable (3.8.2-4) Epiphany/3.8.2

Follow-up Comment #3, patch #7855 (project lwip):

@comparison: `endtime <= now` does not catch the case when now is before the
timer wrap and endtime is after. you'd have to do at least `(endtime >
last_time_i_checked && endtime <= now) || (last_time_i_checked > now &&
endtime <= now)` -- or map times back to be deltas again internally, so that a
subtraction operation will take care of the wraps.

irrespective of that discussion, i support your approach of having a the
timeout functions exchangable, and do welcome an alternative implementation to
provide internal benchmarks. the point of my original comment here was mainly
to state that delta appraoch is not fundamentally broken, and to alert people
who might carelessly want to just drop the delta approach for an absolute
implementation (which wouldn't be you, but others who experience problems with
timeouts and wind up here).

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?7855>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]