[lwip-devel] [bug #38803] Source address in broadcast ping reply

[Jens Nielsen]

URL:
  <http://savannah.nongnu.org/bugs/?38803>

                 Summary: Source address in broadcast ping reply
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: deft
            Submitted on: Mon 22 Apr 2013 13:04:25 GMT
                Category: IPv4
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: 1.4.1

    _______________________________________________________

Details:

I enabled broadcast ping (#define LWIP_BROADCAST_PING 1) and noticed lwip
replies to a broadcast ping with the broadcast address as source address. In
icmp.c the source and destination addresses are simply switched when building
the echo response.

I suppose the attached diff would do the trick (using the netif address as
source address instead)


(ref RFC 1122 section 3.2.2.6 and RFC 1812 section 4.3.3.6, "the source
address in an ICMP Echo Reply MUST be the same as the specific-destination
address of the corresponding ICMP Echo Request message". I.e. the Echo Request
destination address if unicast, or the network interface address in case of
multicast or broadcast)



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 22 Apr 2013 13:04:25 GMT  Name: broadcast_ping.diff  Size: 577B  
By: deft

<http://savannah.nongnu.org/bugs/download.php?file_id=27924>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?38803>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/