[lwip-devel] [patch #8008] Fix a potential null pointer dereference in assert

[Liam]

URL:
  <http://savannah.nongnu.org/patch/?8008>

                 Summary: Fix a potential null pointer dereference in assert
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: morepork
            Submitted on: Wed 10 Apr 2013 09:15:02 PM GMT
                Category: TCP
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

Fix a potential null pointer dereference in assert

diff --git a/src/api/api_msg.c b/src/api/api_msg.c
index b1a9b77..4257500 100644
--- a/src/api/api_msg.c
+++ b/src/api/api_msg.c
@@ -222,11 +222,11 @@ recv_tcp(void *arg, struct tcp_pcb *pcb, struct pbuf *p,
err_t err)
   LWIP_ASSERT("recv_tcp must have a pcb argument", pcb != NULL);
   LWIP_ASSERT("recv_tcp must have an argument", arg != NULL);
   conn = (struct netconn *)arg;
-  LWIP_ASSERT("recv_tcp: recv for wrong pcb!", conn->pcb.tcp == pcb);
-
   if (conn == NULL) {
     return ERR_VAL;
   }
+  LWIP_ASSERT("recv_tcp: recv for wrong pcb!", conn->pcb.tcp == pcb);
+
   if (!sys_mbox_valid(&conn->recvmbox)) {
     /* recvmbox already deleted */
     if (p != NULL) {




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?8008>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/