[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lwip-devel] [bug #38525] Coverity: Recursive Header Inclusion: lwip
From: |
Mason |
Subject: |
Re: [lwip-devel] [bug #38525] Coverity: Recursive Header Inclusion: lwip/src/include/lwip/debug.h |
Date: |
Mon, 18 Mar 2013 10:17:37 +0100 |
User-agent: |
Mozilla/5.0 (Windows NT 5.1; rv:19.0) Gecko/20100101 Firefox/19.0 SeaMonkey/2.16.2 |
Grant Erickson wrote:
> http://savannah.nongnu.org/bugs/?38525
>
> lwip/src/include/lwip/debug.h:36: Recursion in included headers
> (PW.INCLUDE_RECURSION)
> #include file "lwip/src/include/lwip/opt.h" includes itself:
> opt.h -> debug.h -> opt.h (other events go to each file)
> During compilation of file 'lwip/src/api/api_lib.c'
Considering that all the project's header files have inclusion guards,
there is, in fact, no real recursion to speak of, right?
https://en.wikipedia.org/wiki/Include_guard
#ifndef __LWIP_OPT_H__
#define __LWIP_OPT_H__
...
#endif /* __LWIP_OPT_H__ */
We could discuss why it is bad form to define a macro that starts
with two underscores, but that's another subject.
--
Regards.