[lwip-devel] [bug #35928] BSD sockets functions must set errno for POSIX-compliance

[Mason]

Follow-up Comment #10, bug #35928 (project lwip):

Simon Goldschmidt wrote:

> Mason wrote:
> 
>> please consider making LWIP_SOCKET_SET_ERRNO=1 the default.
> 
> Wouldn't LWIP_SOCKET_SET_ERRNO=LWIP_COMPAT_SOCKETS be the correct
> default to prevent lwIP's socket implementation messing with the
> global errno?

(Nit: Under POSIX, errno is not global anymore, it is a
thread-local resource)

In my port, I've defined
#define LWIP_COMPAT_SOCKETS   0
#define LWIP_SOCKET_SET_ERRNO 1
and the BSD-socket function renaming is done in cc.h

Maybe I'm using lwip in a very specialized way. (I need the
real POSIX names exported in the library).

My preference is for LWIP_SOCKET_SET_ERRNO to default to
LWIP_SOCKET, but I won't lose sleep if you pick another
default, now that I set LWIP_SOCKET_SET_ERRNO explicitly
in lwipopts.h (others may fall into this trap however).


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?35928>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/