[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [bug #35945] SYN packet should provide the recv MSS not the
|
From: |
Mason |
|
Subject: |
[lwip-devel] [bug #35945] SYN packet should provide the recv MSS not the send MSS |
|
Date: |
Thu, 22 Mar 2012 13:03:50 +0000 |
|
User-agent: |
Mozilla/5.0 (Windows NT 5.1; rv:11.0) Gecko/20120312 Firefox/11.0 SeaMonkey/2.8 |
Follow-up Comment #1, bug #35945 (project lwip):
More realistic patch:
--- tcp_out.c 2012-02-23 10:57:12.859375000 +0100
+++ tcp_out.c 2012-03-22 13:44:36.750000000 +0100
@@ -1066,7 +1066,11 @@
packets, so ignore it here */
opts = (u32_t *)(void *)(seg->tcphdr + 1);
if (seg->flags & TF_SEG_OPTS_MSS) {
- *opts = TCP_BUILD_MSS_OPTION(pcb->mss);
+ int mss = TCP_MSS;
+#if TCP_CALCULATE_EFF_SEND_MSS
+ mss = tcp_eff_send_mss(TCP_MSS, &pcb->remote_ip);
+#endif
+ *opts = TCP_BUILD_MSS_OPTION(mss);
opts += 1;
}
#if LWIP_TCP_TIMESTAMPS
What remains is the (now) inappropriate function name.
Perhaps tcp_eff_send_mss should be renamed to tcp_eff_mss
and TCP_CALCULATE_EFF_SEND_MSS to TCP_CALCULATE_EFF_MSS?
Comments?
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/bugs/?35945>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/