[lwip-devel] [bug #35541] PPP Memory Leak

[Simon Goldschmidt]

Update of bug #35541 (project lwip):

                  Status:                    None => Need Info              
             Assigned to:                    None => goldsimon              

    _______________________________________________________

Follow-up Comment #1:

I suggest 2 fixes for this:
- in pppOverSerialOpen(), call pbuf_free(pc->rx.inHead) if != NULL before
zeroing 'pc' using memset()
- always call pppRecvWakeup() and reset the pc->rx state in the function
before calling sio_read_abort()

While the first should be enough to fix the leak, the latter is nice to have.

The latter change would require that sio_recv()/sio_read() do not return any
RX bytes if they were aborted (or they would lead to allocating a pbuf
again).

As I'm not in a position to test this (I don't have a working PPP setup), can
you test this from git if I make the changes? If you can test it quickly, I'd
be tempted to add this to 1.4.1...

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?35541>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/