[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lwip-devel] Port on 16 bits processor: problem in ip4_addr_netmask_

From: address@hidden
Subject: Re: [lwip-devel] Port on 16 bits processor: problem in ip4_addr_netmask_valid() function
Date: Fri, 18 Feb 2011 14:32:07 +0100
User-agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; de; rv: Gecko/20101207 Thunderbird/3.1.7

Giuseppe Modugno wrote:
I think IP_OFFMASK and IP_MF (and others) should be declared unsigned ('U' suffix), otherwise the left shifting by 8 positions can could wrong for a signed int.

What do you think?
Found some more and fixed them in CVS HEAD. Please keep us updated on 16-bit progress :-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]