[lwip-devel] [bug #30038] dhcp_network_changed doesn't reset AUTOIP coop state

[Simon Goldschmidt]

Update of bug #30038 (project lwip):

                Category:                    None => IPv4                   
                  Status:                   Fixed => In Progress            
             Assigned to:                    None => goldsimon              
             Open/Closed:                  Closed => Open                   

    _______________________________________________________

Follow-up Comment #8:

I just discovered the patch didn't fix the bug - or introduced another bug,
rather:

- start the device with DHCP/AutoIP-coop without a DHCP server
- wait until it has an AutoIP assigned (bound)
- start/connect the DHCP server
- pull and plug the cable
-> At this time, DHCP starts to run but AutoIP is still running/is restarted,
too. Since DHCP does not stop AutoIP when setting autoip_coop_state to OFF,
both continue to run. Then, if DHCP gets an address first, AutoIP will "win"
since it sets its address later and DHCP does not recognize this.

Proposed fix (which I'll check in) is:

if(dhcp->autoip_coop_state == DHCP_AUTOIP_COOP_STATE_ON) {
  autoip_stop(netif);
  dhcp->autoip_coop_state = DHCP_AUTOIP_COOP_STATE_OFF;
}

(instead of only setting autoip_coop_state to OFF).

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?30038>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/