[lwip-devel] [bug #30447] tcp.c:tcp_bind() - suspicious nested #if

[Iordan Neshev]

URL:
  <http://savannah.nongnu.org/bugs/?30447>

                 Summary: tcp.c:tcp_bind() - suspicious nested #if
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: iordan_neshev
            Submitted on: Wed 14 Jul 2010 04:38:36 PM GMT
                Category: None
                Severity: 3 - Normal
              Item Group: Change Request
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: CVS Head

    _______________________________________________________

Details:

tcp.c, in function tcp_bind() on line 411 there is:

#if SO_REUSE
  /* Unless the REUSEADDR flag is set,
     we have to check the pcbs in TIME-WAIT state, also.
     We do not dump TIME_WAIT pcb's; they can still be matched by incoming
     packets using both local and remote IP addresses and ports to
distinguish.
   */
#if SO_REUSE
  if ((pcb->so_options & SOF_REUSEADDR) != 0) {
    max_pcb_list = NUM_TCP_PCB_LISTS_NO_TIME_WAIT;
  }
#endif /* SO_REUSE */
#endif /* SO_REUSE */

There is one #if SO_REUSE nested. Seems like something is either missing or
not needed.






    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?30447>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/