[lwip-devel] [bug #28127] remove call to tcp_output() from tcp_ack(_now)()

[Simon Goldschmidt]

URL:
  <http://savannah.nongnu.org/bugs/?28127>

                 Summary: remove call to tcp_output() from tcp_ack(_now)()
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: goldsimon
            Submitted on: Mo 30 Nov 2009 06:57:02 GMT
                Category: TCP
                Severity: 1 - Wish
              Item Group: Change Request
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: CVS Head

    _______________________________________________________

Details:

tcp_ack_now() is used 9 times of that only 2 times can result in outputting
segments since with all other tcp_input_pcb==pcb is true.

tcp_ack() is *only* used when tcp_input_pcb==pcb!

For performance and clarity (don't make the developer think tcp_output gets
called when it doesn't, effectively), I propose to remove the call to
tcp_output() from the tcp_ack(_now) defines and to put an explicit call to
tcp_output where it is actually called (and does something) now.




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?28127>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/