[lwip-devel] [bug #26267] Simultaneous close

[Oleg Tyshev]

Follow-up Comment #18, bug #26267 (project lwip):

In reply to comment #13.
I think it would be better get ride of snd_max.
SND_NXT is used in all RFCs.
Why snd_nxt is overwritten by retransmission?
By retransmission segment is moved from unacked queue to unsent queue.

Instead

pcb->snd_nxt = ntohl(seg->tcphdr->seqno) + TCP_TCPLEN(seg);
if (TCP_SEQ_LT(pcb->snd_max, pcb->snd_nxt)) {
   pcb->snd_max = pcb->snd_nxt;
}

we should make something like this

tmp_snd_nxt = ntohl(seg->tcphdr->seqno) + TCP_TCPLEN(seg);
if (TCP_SEQ_LT(pcb->snd_nxt, tmp_snd_nxt)) {
  pcb->snd_nxt = tmp_snd_nxt;
}

tcp_rexmit_rto() and tcp_rexmit() shouldn't modify snd_nxt.


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?26267>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/