[lwip-devel] [bug #25094] Zero-length pbuf

[Charles Landau]

URL:
  <http://savannah.nongnu.org/bugs/?25094>

                 Summary: Zero-length pbuf
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: clandau
            Submitted on: Sun 14 Dec 2008 06:09:03 PM GMT
                Category: TCP
                Severity: 3 - Normal
              Item Group: Feature Request
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: 1.3.0

    _______________________________________________________

Details:

In core/tcp_out.c, starting at line 336 the code appends the pbuf chain
queue->p to the unsent queue useg. When so doing it removes the TCP header
from queue->p because useg already has a header.

It can happen that the pbuf chain queue->p is a chain of two (or more) pbufs,
the first of which has only a TCP header (added at line 258). Removing the TCP
header leaves this pbuf with a zero length. Appending this to useg using
pbuf_cat() leaves the zero length pbuf in the chain. This leaves a useless
zero length pbuf allocated and taking up space limited by TCP_SND_QUEUELEN.

I suggest in this case the zero length pbuf should be freed and only the rest
of its chain appended to useg.

Even better, if it is possible, would be to not add a TCP header until it is
known that the packet won't be concatenated to the queue. 




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?25094>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/