[lwip-devel] [patch #6370] Sending to myself

[Luca Ceresoli]

Follow-up Comment #22, patch #6370 (project lwip):

Tested and working! (NO_SYS=1)

Just a couple of very minor issues:

> --- netif.c   2008/06/12 20:10:09     1.66
> +++ netif.c   2008/06/17 19:39:22     1.67
> @@ -47,6 +47,8 @@
>  #include "netif/etharp.h"
>  #if ENABLE_LOOPBACK && !LWIP_NETIF_LOOPBACK_MULTITHREADING
>  #include "lwip/sys.h"
> +#else /* ENABLE_LOOPBACK && !LWIP_NETIF_LOOPBACK_MULTITHREADING */
> +#include "lwip/tcpip.h"
>  #endif /* ENABLE_LOOPBACK && !LWIP_NETIF_LOOPBACK_MULTITHREADING */
 
tcpip.h would be included when ENABLE_LOOPBACK==0 and
LWIP_NETIF_LOOPBACK_MULTITHREADING==0.
Also, the protect macros in sys.h are required for ENABLE_LOOPBACK, any
NO_SYS value.

I think it should be:
#if ENABLE_LOOPBACK
#include "lwip/sys.h"
#if LWIP_NETIF_LOOPBACK_MULTITHREADING
#include "lwip/tcpip.h"
#endif /* LWIP_NETIF_LOOPBACK_MULTITHREADING */
#endif /* ENABLE_LOOPBACK */

> --- netif.h   2008/06/12 20:10:10     1.44
> +++ netif.h   2008/06/17 19:39:22     1.45
> ...
> +#if LWIP_LOOPBACK_MAX_PBUFS
> +  u16_t loop_cnt_max;
> +  u16_t loop_cnt_current;
> +#endif /* LWIP_LOOPBACK_MAX_PBUFS */

Why a variable for the max value? It will nevere be changed after init.


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6370>

_______________________________________________
  Messaggio inviato con/da Savannah
  http://savannah.nongnu.org/