[lwip-devel] [bug #21433] Calling mem_free/pbuf_free from interrupt context isn't safe

[Simon Goldschmidt]

Follow-up Comment #16, bug #21433 (project lwip):

> I'm slightly unsure about referring to disabling interrupts all the time

You're right on that.

> I think the opt.h comment could clarify that pbuf_free_int (and
> mem_free) are functions which already exist and don't need
> writing. Perhaps this should also be documented somewhere else? Wiki?

I changed that a little: I created pbuf_free_callback() and
mem_free_callback() (in tcpip.c, since they only can be used with the
tcpip_thread). Of course this whole problem must be documented somewhere,
opt.h can only be a quick hint: writing more would bloat the file...

> [comment #10]...

Honestly, I'm not sure I completely understand your idea: You want to
unprotect mem_MALLOC (your comment said mem_free) during the search for a free
block and restart the search if a free comes between that? That would make
mem_malloc slower every time only because few times, mem_free could be called!
Personally, I think that would be bad design (making the common case slower to
be able to cope with an uncommon case)...

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?21433>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/