Re: [lwip-devel] Few suggestions for lwip 1.3 RC1

[Kieran Mansley]

On Fri, 2008-02-01 at 12:00 +0100, Iordan Neshev wrote:
> Hello
> 
> There is a short list of what I had to do to run lwip on the
> embedded platform. Under msvc port I didn't see them
> because I did not try to use PPP
> 
> 1. /ppp/magic.c
> should begin with:
> #include "ppp.h"   // or maybe lwip/opt.h and move #include "ppp.h" 
> below #if PPP_SUPPORT
> 
> #if PPP_SUPPORT   // this is the missing line
> 
> #include "randm.h"
> #include "magic.h"
> ...
> and end with #endif  /* PPP_SUPPORT */
> 
> 2. core/ipv4/inet_chksum.c
> add #include <string.h> because NULL is used, but not #defined.
> Seems like some compilers silently define NULL, and some do not.
> 
> 3. ppp/ppp.c
> 
> add #include "lwip/ip.h" which defines ip_input (referenced at line 1337)

1-3 all done, I'll check this in.

> 4. mem.h
> mem_size_t - there was a discussion in other thread. I'm just reminding you.
> The proposal of Simon seems perfect, but note that this type is used 
> also in stats.h.

I'll leave this for the other thread to resolve.

Kieran