[lwip-devel] [patch #6369] ip_input : checking before realloc

[Jonathan Larmour]

Follow-up Comment #1, patch #6369 (project lwip):

Something doesn't seem right here - pbuf_realloc shouldn't crash because
right at the start it does:
  if (new_len >= p->tot_len) {
    /* enlarging not yet supported */
    return;
  }

Worst case the pbuf isn't trimmed.

And if we did want to make a check like this, it could be merged into the
header length check to save code. (You could just retest to get the desired
LWIP_DEBUGF message - but duplicated test is ok given that that code would be
optimised away by the compiler when lwIP debugging is off).


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6369>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/