[lwip-devel] [task #7525] Implement TCP listen backlog

[Frédéric Bernon]

Update of task #7525 (project lwip):

         Planned Release:                    None => 1.3.0                  

    _______________________________________________________

Follow-up Comment #23:

Some remarks about last check in:

- in api_lib.c, we can read in the comment "@param backlog the listen backlog
(0 = max), only used if LWIP_LISTEN_BACKLOG==1", but I don't see where 0 got
such behavior. More, if backlog = 0, lwip_listen will raise an assert
"LWIP_ASSERT("backlog must be between 0 and 255", backlog > 0);".

- We have to to set LWIP_LISTEN_BACKLOG to 0 per default to avoid to break
the default behavior. Why finally enable it per default in opt.h?

- jifl suggested in comment#14 to do the same api change (but with
compatibility) for tcp_listen. It would give something like :

struct tcp_pcb * tcp_listen_with_backlog(struct tcp_pcb *pcb, u8_t backlog);
#define tcp_listen(pcb) tcp_listen_with_backlog(pcb,
LWIP_MAX_LISTEN_BACKLOG); 

In this case, we could remove tcp_backlog macro. I'm in flavor of this
solution.

- LWIP_DEFAULT_LISTEN_BACKLOG is a best name than LWIP_MAX_LISTEN_BACKLOG,
but since this feature is now available in raw API, perhaps we should rename
these options in TCP_LISTEN_BACKLOG and TCP_DEFAULT_LISTEN_BACKLOG ?



    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?7525>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/