[lwip-devel] [bug #21664] PPP code is broken

[Simon Goldschmidt]

Follow-up Comment #4, bug #21664 (project lwip):

embed9527 wrote on lwip-users:
> 4、In the file vjbsdhdr.h, the struct in_addr in the file
> ip_addr.h(line 70-72) must to changed as:
>  
> PACK_STRUCT_BEGIN
> struct in_addr {
>   PACK_STRUCT_FIELD(u32_t s_addr);
> }PACK_STRUCT_STRUCT;
> PACK_STRUCT_END
>  
> after change, the struct ip in file vjbsdhdr.h, the variable
> struct in_addr ip_src,ip_dst(line 39) can compiler successfully.

I think the error is in vjbsdhdr.h: The struct ip.ip_src and .ip_dst should
be of type struct ip_addr, not in_addr: struct in_addr is used for API only
and shouldn't need to be packed!

On the other hand this type (and struct tcphdr) is really not needed, since
lwIP defines them in ip.h and tcp.h already!

Seems like there are many duplicates in ppp...

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?21664>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/