[lwip-devel] [bug #21491] TCP MSS sent is based on the received MSS option

[Simon Goldschmidt]

URL:
  <http://savannah.nongnu.org/bugs/?21491>

                 Summary: TCP MSS sent is based on the received MSS option
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: goldsimon
            Submitted on: Donnerstag 01.11.2007 um 16:02
                Category: TCP
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 

    _______________________________________________________

Details:

Currently, the MSS option sent in tcp_connect (active open) and
tcp_listen_input (passive open) is based on pcb->mss instead of TCP_MSS.

While in tcp_connect, this is is OK (because pcb->mss is set to TCP_MSS just
before), this leads to advertising the remote MSS in tcp_listen_input.

I'd make this a define TCP_BUILD_MSS_OPTION() (that's based on TCP_MSS) in
both cases, which also removes redundant source code.

Any objections?




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?21491>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/