RE : RE : [lwip-devel] Can we remove pbuf_init()

[Frédéric BERNON]

>I agree with Frederic, although I also think there's a lot more could be 
done to improve stack initialisation so users don't need to make all these 
individual subsystem initialisation calls.

We have already talk about a "lwip_init" function to initialize all sub 
systems. But it doesn't seem to be a idea that everyone like !!!

>#define pbuf_init() do { } while (0)

I'm always suprised about this kind of macro (the do/while(0)). Most of time, 
it's generate lot of warnings. Of couse, it's perhaps compiler-dependant. I 
don't understand why don't write "define pbuf_init()" ? Can you explain me 
when/why such code writing ?

====================================
Frédéric BERNON 
HYMATOM SA 
Chef de projet informatique 
Microsoft Certified Professional 
Tél. : +33 (0)4-67-87-61-10 
Fax. : +33 (0)4-67-70-85-44 
Email : address@hidden 
Web Site : http://www.hymatom.fr 
====================================
P Avant d'imprimer, penser à l'environnement
 


-----Message d'origine-----
De : address@hidden [mailto:address@hidden De la part de Jonathan Larmour
Envoyé : vendredi 27 juillet 2007 16:48
À : lwip-devel
Objet : Re: RE : [lwip-devel] Can we remove pbuf_init()


[ Old message I know ]
Frédéric BERNON wrote:
> Uhmm, it will not change a lot the footprint, but is done for future 
> uses. So, to my point of view, it's better to let it. But it really 
> cause you any problems, remove it...

I agree with Frederic, although I also think there's a lot more could be 
done to improve stack initialisation so users don't need to make all these 
individual subsystem initialisation calls.

Perhaps:
  #define pbuf_init() do { } while (0)
so there's no code overhead.

Jifl

> -----Message d'origine-----
> De : address@hidden 
> [mailto:address@hidden De 
> la part de Goldschmidt Simon Envoyé : lundi 11 juin 2007 12:39 À : 
> lwip-devel Objet : [lwip-devel] Can we remove pbuf_init()
> 
> 
> 
> It doesn't do anything any more, only checks alignment of 
> PBUF_POOL_BUFSIZE. It's simpler changing the use of PBUF_POOL_BUFSIZE 
> in pbuf.c (and some other files) to MEM_ALIGN_SIZE(PBUF_POOL_BUFSIZE).
> 
> Or does anyone need pbuf_init() (maybe for the future)???
> 
> I'll remove it if noone objects ;-)
> 
> 
> Simon
> 
> 
> _______________________________________________
> lwip-devel mailing list
> address@hidden 
> http://lists.nongnu.org/mailman/listinfo/lwip-devel
> 
> 
> ----------------------------------------------------------------------
> --
> 
> _______________________________________________
> lwip-devel mailing list
> address@hidden 
> http://lists.nongnu.org/mailman/listinfo/lwip-devel


-- 
eCosCentric Limited      http://www.eCosCentric.com/     The eCos experts
Barnwell House, Barnwell Drive, Cambridge, UK.       Tel: +44 1223 245571
Registered in England and Wales: Reg No 4422071.
------["The best things in life aren't things."]------      Opinions==mine


_______________________________________________
lwip-devel mailing list
address@hidden http://lists.nongnu.org/mailman/listinfo/lwip-devel

Frédéric BERNON.vcf
Description: Frédéric BERNON.vcf