[lwip-devel] [task #6861] Pimp ip_frag.c

[Jonathan Larmour]

Follow-up Comment #19, task #6861 (project lwip):

>From just visually looking at the code, it looks good.  Just two minor
thoughts though:

a) should we instead reset the timer value for a reassembled buffer each time
a fragment is received?

Imagine a 38400 bps modem - a 64Kbyte IP packet (consisting of many
fragments) would take at least 13 seconds to receive. Sure, the developer can
tweak IP_REASS_MAXAGE, but it just seems better to me that if the packet
transmission is not yet stopped, we don't allow the reassembly to time out.

b) At various points the constant IP_HLEN is used for the header length. But
shouldn't this be using the supplied header length within the header, given
the possibility of options?


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?6861>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/