[lwip-devel] [bug #20021] conn->sem is only signaled one-way

[Simon Goldschmidt]

Follow-up Comment #25, bug #20021 (project lwip):

Hmm, I remember posting an answer to comment #21 some time but I can't find
it now, so that probably didn't work :-)

> - "enum tcp_state old_state = conn->pcb.tcp->state;
if ((old_state == SYN_RCVD) || (old_state == ESTABLISHED) ||
(old_state == CLOSE_WAIT)) {"
Why do you use a local variable and a "if" in this case, and not a switch
like for "err" some lines below?

Dunno. I can change that if you like.

> Even if it's no explicitly in our coding style, default is always the last
clause in our switchs. Why isn't it the case here

Note the /*fall through*/ comment. 'default' needs nearly the same action as
ERR_MEM and ERR_OK, so it has to be above them to get small code. But I'll
change that (see the comment below)

> and why putting () around err_t case (like "case (ERR_OK):" ?

Dunno, it's our coding style at work. It's hard to prevent mixing the styles
every time... I'll change that, too.

>  feel dangerous to determine if FIN is sent or not which "err" return
value

I'll think of something for that.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?20021>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/