[lwip-devel] [bug #20409] Add netif callback function for link change event

[Frédéric Bernon]

Follow-up Comment #51, bug #20409 (project lwip):

>Also we need to work on the timer functions if we implement
netif_set_link_down/up like that. Without it, it's not worth anything.

Yes, but I think it's to the port to call the function (you can have an IT,
have already a thread or a timer to handle the board, etc..).

>And the feature 'set MAC to low power mode' does not work with this patch,
does it?

In fact, If Jared want to "power off" his MAC, he can use the
"status_callback" to do that.

Simon, I propose to check in the patch with comment#44 changes (but always
with both callback), and to patch ethernetif.c to set the NETIF_FLAG_LINK_UP,
+ opts.h + CHANGELOG. Like this, the code doesn't change if
LWIP_NETIF_LINK_CALLBACK=0, and the modification is not intrusive. Like this,
Jared can have his initial feature, and we could improve that
(dhcp,autoip,igmp) in next release. Agree for you ?

 



    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?20409>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/