[lwip-devel] [bug #20318] api_msg "recv" callbacks don't call pbuf_free in all error cases

[Frédéric Bernon]

URL:
  <http://savannah.nongnu.org/bugs/?20318>

                 Summary: api_msg "recv" callbacks don't call pbuf_free in
all error cases
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: fbernon
            Submitted on: lundi 02.07.2007 à 16:53
                Category: None
                Severity: 2 - Minor
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: fbernon
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

recv_udp & recv_tcp check is the conn->recvmbox is valid before post the
pbuf/netbuf. I think they should call pbuf_free is the mailbox is invalid,
and this is not the case. Even if this case should not appear, we should
process it (or if we think it never appear, we should remove the test, and
replace it by an assert).

I think there is no problem with recv_raw, since this callback should never
"eat" the packets...

Can I have your comments about that?





    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?20318>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/