[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [task #6880] netconn API misses some error forwarding

From: Frédéric Bernon
Subject: [lwip-devel] [task #6880] netconn API misses some error forwarding
Date: Mon, 14 May 2007 08:10:00 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv: Gecko/20070309 Firefox/

Follow-up Comment #1, task #6880 (project lwip):

I can check it if you want. 

If I look in api_msg.c, most of functions report "local" error with a
"msg->conn->err = err;" before the "sys_mbox_post", like in :


What do you prefer? Directly set conn->err, or only update it at the end?

In a general way, in "do_" functions, some "case" are done where they do
nothing, like in do_close (only "case NETCONN_TCP:" is really usefull).
Others, like do_write, set errors like "msg->conn->err = ERR_VAL;". I propose
to replace most of TCP specific "switch"  by a simple "if
(msg->conn->type==NETCONN_TCP)" (code would be simpler, and a switch can't be
optimized by compiler).


Reply to this item at:


  Message posté via/par Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]