[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #5926] Use function pointers instead of table index

From: Simon Goldschmidt
Subject: [lwip-devel] [patch #5926] Use function pointers instead of table index in api_lib/api_msg
Date: Fri, 11 May 2007 07:15:25 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv: Gecko/20070309 Firefox/

Follow-up Comment #4, patch #5926 (project lwip):

I think replacing the 'type' field with a 'function' field is rather
straightforward and that part of the patch looks good to me.

I just have three little remarks on the rest:
- Why do you mark the do_*() functions as extern? We don't have that anywhere
in the stack (except for lwip_strerr() and some ppp functions). Wouldn't
extern mean the functions are in another library?
- I would favour defining api_msg_post() to tcpip_apimsg() instead of
tcpip_apimsg(). That way we're still open to let it do something else and
code size stays the same.
- What is it with this variable 'msg_copy'? Why was it used and why is it
obsolete, now?

And I agree on comment #2!


Reply to this item at:


  Nachricht geschickt von/durch Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]