[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [patch #5865] Fix missing lwip directory in socket.h includ
From: |
Frédéric Bernon |
Subject: |
[lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path |
Date: |
Fri, 20 Apr 2007 06:20:40 +0000 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3 |
Follow-up Comment #6, patch #5865 (project lwip):
Hi,
I think that the patch is good, and that tcp.h must stay here to reach some
options defines like TCP_NODELAY, TCP_KEEPALIVE, .... If yo really want to
remove it, think to add all necessary defines in sockets.h.
Note that because some others include like opt.h and ip_addr.h are necessary,
I don't understand why tcp.h will cause a problem...
And you will have to maintain a compatible table like SO_ options (in
sockets.h) and SOF_ options (in ip.h), like this example :
#define SO_BROADCAST 0x0020 /* permit sending of broadcast msgs */
#define SOF_BROADCAST (u16_t)0x0020U /* permit sending of broadcast msgs
*/
And to my point of view, it's not very nice...
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?5865>
_______________________________________________
Message posté via/par Savannah
http://savannah.nongnu.org/
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Tai-hwa Liang, 2007/04/12
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Kieran Mansley, 2007/04/12
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Simon Goldschmidt, 2007/04/19
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Jonathan Larmour, 2007/04/19
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Simon Goldschmidt, 2007/04/19
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Tai-hwa Liang, 2007/04/19
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path,
Frédéric Bernon <=
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Simon Goldschmidt, 2007/04/20
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Kieran Mansley, 2007/04/20
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Simon Goldschmidt, 2007/04/20
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Jonathan Larmour, 2007/04/20