[lwip-devel] [bug #19432] netbuf_ref doesn't check pbuf_alloc result

[Frédéric Bernon]

Follow-up Comment #6, bug #19432 (project lwip):

Ok to set "buf->ptr = NULL;" only if (buf->p == NULL), it's better.

About length fields, ???, what length field? I don't understand. There is no
such field in netbuf. Or you talk about this line?

buf->p->len = buf->p->tot_len = size;

But if it's right, if buf->p==NULL, then we don't have len and tot_len.

Last, in struct netbuf, there is a "err_t err;" field which is never used. I
propose to remove.

Ok to commit without the "err_t err;", and with "buf->ptr = NULL;" only if
(buf->p == NULL)?


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19432>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/