[lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton

[Thomas Taranowski]

URL:
  <http://savannah.nongnu.org/bugs/?19177>

                 Summary: Faulty arp initialization in ethernetif_init
skeleton
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: taranowski
            Submitted on: Thursday 03/01/2007 at 07:30
                Category: ARP
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

The ethernetif_init skeleton executes the following code:


  ethernetif->ethaddr = (struct eth_addr *)&(netif->hwaddr[0]);

  low_level_init(netif);

  etharp_init();

  sys_timeout(ARP_TMR_INTERVAL, arp_timer, NULL);

  return ERR_OK;
}

When multiple network interfaces are instantiated, usually via the netif_add
routine, the etharp_init is executed, and the arp timer start for each
instantiation.  This is not desired behaviour, and results in multiple
instances of the arp_timer timer, which is bad, and causes the arp_timer
function to be run more frequently than expected.

I've attached a patch file that wraps the arp initialization such that it is
executed at most, only one time.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Thursday 03/01/2007 at 07:30  Name: ethernetif.patch  Size: 951B   By:
taranowski

<http://savannah.nongnu.org/bugs/download.php?file_id=12080>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19177>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/