[lwip-devel] [bug #19052] ppp.h version 1.2 has broken Macros GETSORT/LONG

[anonymous]

URL:
  <http://savannah.nongnu.org/bugs/?19052>

                 Summary: ppp.h version 1.2 has broken Macros GETSORT/LONG
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: None
            Submitted on: Tuesday 02/13/2007 at 16:39 UTC
                Category: Contrib
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

#define GETSHORT(s, cp) { \
    (s) = *(cp); (cp)++; (s) << 8; \
                         ^^^^^^^^ useless
    (s) |= *(cp); (cp)++; \
}

Version 1.1 was correct:
#define GETSHORT(s, cp) { \
    (s) = *(cp)++ << 8; \
    (s) |= *(cp)++; \
}

Same for GETLOG, with the resolt, that PPP connections fails
with bad LCP states...




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19052>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/