Re: [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. STABLE-2_1_0_RELEASE-360-g6e7ea92

[address@hidden]

Am 15.02.2020 um 21:03 schrieb Sylvain Rochet:
> Hi Simon,
> 
> On Sat, Feb 15, 2020 at 02:54:40PM -0500, Simon Goldschmidt wrote:
>>
>>     ppp: fix compiling with CCP_SUPPORT=1 but MPPE_SUPPORT=0
>>     
>>     Even if that might not make much sense, it still shouldn't
>>     result in compiler warnings.
>>     
>>     Signed-off-by: Simon Goldschmidt <address@hidden>
> 
> It's harmless doing so indeed, but the right check is to abort the 
> compilation if none of DEFLATE_SUPPORT, BSDCOMPRESS_SUPPORT, 
> PREDICTOR_SUPPORT, or MPPE_SUPPORT are set while CCP_SUPPORT is set.

Feel free to add such a compile-time check for sane configuration. I
don't have the protocol knowledge to do so.

My target is to allow random config builds: I'm working a bit on
converting opt.h and otehr build options to Kconfig and implementing
random config builds to cover such failures (we have too many ifdefs
that can break at any time because some combinations are seldom used).

Regards,
Simon

> 
> (I know there are no data flow handling code for DEFLATE, BSDCOMPRESS 
> and PREDICTOR, so they are currently "quite" useless :p)
> 
> Sylvain
>

signature.asc
Description: OpenPGP digital signature