Re: [Ltib] [PATCH] Fix colilo build when using fully relocatable toolchains. : docu

[Stuart Hughes]

Hi Carlos,

Thanks for the patch.  What you say makes sense.  I hadn't realised that
stuff was in the colilo package.

Normally to make minor patches like this, you can run ./ltib -m
patchmerge (it looks like you did?).

That will create an actual patch-file and put it into <basedir>/pkgs.
You'll get a name like colilo-0.3.3-nnnnnnnn.patch.  The nnnn bit is
just a time in seconds since the epoch.  The idea is to make sure it's
likely to be unique as nothing ever gets replaced/modified in the GPP.
Also patchmerge will also update the colilo.spec file and add the new
patch in so that next time you build it will use the new patch.

Normally I re-name my patches to something more meaningful (after
checking it is unique) and I then change the reference in the spec file.
Having done all that you can then either:  send the patch and a cvs diff
to the mailing list (attachments work best for me, I never know how to
avoid whitespace mangling in email clients).  Alternatively, if you're
going to be actively working on LTIB and you want to be a developer,
after I've got some confidence, I'd add the person to the list of
developers.  This would mean they can upload directly to the GPP
(http://www.bitshrine.org/cgi-bin/gpp_upload.cgi ) and do their own CVS
commits.

For this particular case, I can check in the change if you like? Let me
know.

Regards, Stuart

On Wed, 2006-12-06 at 23:31 -0500, Carlos O'Donell wrote:
> Stuart, Matt,
> 
> When compiling with a fully relocatable toolchain colilo fails to compile.
> 
> The variable GCC_EXEC_PREFIX has a special meaning to the compiler, see:
> http://gcc.gnu.org/onlinedocs/gcc-4.1.1/gcc/Environment-Variables.html#Environment-Variables
> 
> If care is not taken with GCC_EXEC_PREFIX the compiler may fail to find
> cc1. It would be best in the case of colilo to avoid GCC_EXEC_PREFIX and
> use TOOLCHAIN_PREFIX instead.
> 
> The following patch fixed colilo build failures when compiling with
> CodeSourcery's Sourcery G++ Coldfire GNU/Linux toolchain. The
> CodeSourcery toolchains are fully relocatable toolchains i.e. you can
> put them anywhere, and they honour the GCC_EXEC_PREFIX environment
> variable.
> 
> The ltib FAQ was indispensible, in particular "How do I make changes to
> a package and capture them" was very useful!
> 
> What sort of patches / diffs / testing are you looking for?
> 
> It appears this patch just applies ontop of the existing colilo pathes
> and would get added to the colilo.spec file?
> 
> Cheers,
> Carlos.