[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] [lmi-commits] master 93e400db 10/13: Avoid literal '***' in a

From: Vadim Zeitlin
Subject: Re: [lmi] [lmi-commits] master 93e400db 10/13: Avoid literal '***' in a 'set -vx' script
Date: Tue, 22 Nov 2022 16:23:28 +0100

On Mon, 21 Nov 2022 17:29:19 -0500 (EST) Greg Chicares 
<gchicares@sbcglobal.net> wrote:

GC> branch: master
GC> commit 93e400db7168525309689fec38a29cc55d41c81c
GC> Author: Gregory W. Chicares <gchicares@sbcglobal.net>
GC> Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
GC>     Avoid literal '***' in a 'set -vx' script
GC>     Echoing lines that contain '***' makes it harder to find actual errors
GC>     that are marked '***'.
GC> ---
GC>  install_xml_libraries.sh | 14 +++++++-------
GC>  1 file changed, 7 insertions(+), 7 deletions(-)

 FWIW I had originally used '***' there precisely in order to be able to
find these lines quickly by grepping for this character sequence. IOW this
coincidence was intentional and not random. I admit I didn't think about
looking at "set -x" output, but maybe we could get the best of both worlds
by doing something like

        echo "${error_marker} Configuring failed ..."



Attachment: pgpDswd725Yab.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]