Re: [lmi] Regression in group-quote PDF

[Greg Chicares]

On 2020-08-13 20:15, Vadim Zeitlin wrote:
> On Sat, 8 Aug 2020 18:57:47 +0000 Greg Chicares <gchicares@sbcglobal.net> 
> wrote:
[...]
> GC> +    // PDF !! This should not be necessary--see:
> GC> +    //   https://lists.nongnu.org/archive/html/lmi/2020-08/msg00003.html
> GC> +    wxDCTextBgModeChanger set_transparent_background(pdf_dc, 
> wxPENSTYLE_TRANSPARENT);
> 
>  The argument is actually supposed to be wxBRUSHSTYLE_TRANSPARENT, but it
> has exactly the same value as wxPENSTYLE_TRANSPARENT (and both have the
> same value as just wxTRANSPARENT), so I don't think it's worth changing it,
> especially as this line will be removed anyhow in the near future.

In 'include/wx/dc.h', I saw that wxDCTextBgModeChanger delegates
to SetBackgroundMode(), whose definition is
  virtual void SetBackgroundMode(int mode)
    {m_pimpl_->SetBackgroundMode(mode);}
and the permissible values of 'mode' aren't specified there.
The test for wxBRUSHSTYLE_INVALID seems to imply that a
"brush style" is wanted, but instead I followed the
documentation, which seemed unmistakably clear (even if
somewhat surprising):

  
https://docs.wxwidgets.org/trunk/classwx_d_c.html#a86c405ae265e6fdb4e393c4c9ada73c0
  "mode may be one of wxPENSTYLE_SOLID and wxPENSTYLE_TRANSPARENT."

Is that documentation incorrect?