[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] [lmi-commits] master aee9f4d 10/11: For cygwin, add msw system

From: Vadim Zeitlin
Subject: Re: [lmi] [lmi-commits] master aee9f4d 10/11: For cygwin, add msw system directory to minimal path
Date: Thu, 9 May 2019 01:02:08 +0200

On Wed, 8 May 2019 19:43:16 +0000 Greg Chicares <address@hidden> wrote:

GC> If you would give me the magic string to insert here:
GC> -        minimal_path="$minimal_path:/cygdrive/c/Windows/system32"
GC> +        minimal_path="$minimal_path:...just add magic..."
GC> then I'd be glad to apply it.

 By a pure coincidence, I've just noticed that cygpath actually has an
option for returning this directory directly: "-S" or "--sysdir". So you
could also apply an even simpler and more obviously correct patch:

---------------------------------- >8 --------------------------------------
diff --git a/install_msw.sh b/install_msw.sh
index b47524719..5a6090169 100755
--- a/install_msw.sh
+++ b/install_msw.sh
@@ -40,7 +40,7 @@ minimal_path=${MINIMAL_PATH:-"/usr/bin:/bin:/usr/sbin:/sbin"}

 case "$lmi_build_type" in
-        minimal_path="$minimal_path:/cygdrive/c/Windows/system32"
+        minimal_path="$minimal_path:$(cygpath --sysdir)"

---------------------------------- >8 --------------------------------------

 Sorry for the delay, my esprit de l'escalier seems to be as good as ever...

reply via email to

[Prev in Thread] Current Thread [Next in Thread]