[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] [lmi-commits] odd/fixups 45e7da7 1/4: Replace literal "gcc" wi

From: Vadim Zeitlin
Subject: Re: [lmi] [lmi-commits] odd/fixups 45e7da7 1/4: Replace literal "gcc" with $LMI_COMPILER
Date: Tue, 7 May 2019 01:18:41 +0200

On Mon,  6 May 2019 19:06:58 -0400 (EDT) Greg Chicares <address@hidden> wrote:

GC> branch: odd/fixups
GC> commit 45e7da7a2560f6c2e5642354bbd2e1e9ef8754b2
GC> Author: Gregory W. Chicares <address@hidden>
GC> Commit: Gregory W. Chicares <address@hidden>
GC>     Replace literal "gcc" with $LMI_COMPILER
GC>     This change seems necessary to allow building with a different compiler.
GC> ---
GC>  install_wx.sh | 4 ++--
GC>  1 file changed, 2 insertions(+), 2 deletions(-)
GC> diff --git a/install_wx.sh b/install_wx.sh
GC> index 294da80..ab8f54b 100755
GC> --- a/install_wx.sh
GC> +++ b/install_wx.sh
GC> @@ -89,7 +89,7 @@ case "$build_type" in
GC>  esac
GC>  # Distinguish wx dll by host type, compiler version, and wx SHA1.
GC> -gcc_version=$(${mingw_bin_dir}${LMI_TRIPLET}-gcc -dumpversion|tr -d '\r')
GC> +gcc_version=$(${mingw_bin_dir}${LMI_TRIPLET}-$LMI_COMPILER -dumpversion|tr 
-d '\r')
GC>  vendor=${LMI_TRIPLET}-$gcc_version-$wx_commit_sha
GC>  # Configuration reference:
GC> @@ -135,7 +135,7 @@ config_options="
GC>  [ -n "$mingw_bin_dir" ] && export PATH="$mingw_bin_dir:${PATH}"
GC> -build_dir="$prefix"/../wx-ad_hoc/lmi-gcc-$gcc_version
GC> +build_dir="$prefix"/../wx-ad_hoc/lmi-$LMI_COMPILER-$gcc_version

 This is just cosmetic, but shouldn't we rename gcc_version to
compiler_version too, after doing this?

 Also, more serious, but also more difficult to do anything about, issue is
that few compilers seem likely to have a "-dumpversion" option and even
though clang does provide it, it returns nonsensical values:

% for v in 5.0 6.0 7; echo "clang $v identifies as `clang++-$v -dumpversion`"
clang 5.0 identifies as 4.2.1
clang 6.0 identifies as 4.2.1
clang 7 identifies as 4.2.1

(clang does have a working "--version" option working similarly to g++
option with the same name).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]