Re: [lmi] [lmi-commits] master d0bb8a0 2/6: Add some apparently-missing CXX flags

[Vadim Zeitlin]

On Wed, 25 Jul 2018 21:11:31 -0400 (EDT) Greg Chicares <address@hidden> wrote:

GC> branch: master
GC> commit d0bb8a0662d9ef9fe5873e0d1f6de8075c21d715
GC> Author: Gregory W. Chicares <address@hidden>
GC> Commit: Gregory W. Chicares <address@hidden>
GC> 
GC>     Add some apparently-missing CXX flags
GC> ---
GC>  Makefile.am | 2 ++
GC>  1 file changed, 2 insertions(+)
GC> 
GC> diff --git a/Makefile.am b/Makefile.am
GC> index 40a1d47..c9d159a 100644
GC> --- a/Makefile.am
GC> +++ b/Makefile.am
GC> @@ -797,6 +797,7 @@ test_interpolate_string_SOURCES = \
GC>    $(common_test_objects) \
GC>    interpolate_string.cpp \
GC>    interpolate_string_test.cpp
GC> +test_interpolate_string_CXXFLAGS = $(AM_CXXFLAGS)
GC>  
GC>  test_irc7702a_SOURCES = \
GC>    $(common_test_objects) \
GC> @@ -990,6 +991,7 @@ test_rate_table_SOURCES = \
GC>    path_utility.cpp \
GC>    rate_table.cpp \
GC>    rate_table_test.cpp
GC> +test_rate_table_CXXFLAGS = $(AM_CXXFLAGS)
GC>  test_rate_table_LDADD = \
GC>    $(BOOST_LIBS) \
GC>    $(XMLWRAPP_LIBS)

 This is not really important but, just to understand what's going on, what
problem exactly does the above change solve? It's my understanding that
AM_CXXFLAGS is used by default if ${target}_CXXFLAGS is not defined, see

https://www.gnu.org/software/automake/manual/html_node/Program-Variables.html

And if I'm right about this, adding the above lines should basically have
no effect whatsoever. Of course, I could be wrong, but doing

        $ make -n interpolate_string_test.o AM_CXXFLAGS=FOOBAR

(without the change above), the command that would be executed looks all
right to me, i.e. it does show "FOOBAR" in it.

 So perhaps this change is really unnecessary, after all?
VZ