Re: [lmi] Preserving configurable settings after GUI test

[Vadim Zeitlin]

On Thu, 12 Jul 2018 18:07:44 +0000 Greg Chicares <address@hidden> wrote:

[...]
GC> Finding objections (above) to the others, I went ahead and committed 1.

 Thanks!

 Using the new function, I could update the test to preserve the
configuration settings and the results are here:

                https://github.com/vadz/lmi/pull/88

 Unfortunately, as you can see, this isn't exactly pretty, but this is the
price to pay for carefully handling all errors and trying to produce the
most informative error messages if they happen. As the commit message
mentions, things could be quite a bit simpler if we preserved the original
contents only in memory, and not in a temporary disk file, but this would
be less robust as configurable_settings.xml contents could still be lost
and I decided to err on the side of safety -- please let me know if you
think it's an overkill.

 Also, I used wxWidgets classes and functions because they provide some
functionality not available neither from boost nor std::filesystem
libraries and, as this code already uses wxWidgets anyhow, there didn't
seem to be any reason not to use them -- but, again, please let me know if
you disagree.

 Of course, any other comments are welcome as well, although I might need
some time to address them, as I won't be available until next Friday.

 Regards,
VZ