Re: [lmi] libstdc++ in gcc-7.3.0: std::vector<incomplete_type>

[Greg Chicares]

On 2018-04-24 21:20, Vadim Zeitlin wrote:
> On Tue, 24 Apr 2018 20:14:10 +0000 Greg Chicares <address@hidden> wrote:
> 
> GC> On 2018-04-24 18:04, Greg Chicares wrote:
> GC> > On 2018-04-24 14:26, Vadim Zeitlin wrote:
> GC> [...]
> GC> >>  I can't help wondering why
> GC> >> exactly can't this class be moved in wx_table_generator.cpp?
> GC> > 
> GC> > I would very much like to move it there, but I tried doing exactly that,
[...]
> So this points immediately to the problem: we can't compile inline
> columns_count() without full column_info class definition. But this is not
> really a problem at all, we just need to move columns_count() out of line
> and define it in wx_table_generator.cpp too.

Okay, I moved both inline functions out of line.

>  After this there is another error left and here, to be fair, even clang
> error message is not particularly clear, but it's still not difficult to
> see that it's an example of the same problem as with columns_count(),
> except that now it happens in an implicitly defined function, namely
> wx_table_generator dtor. It is enough to declare it (but _not_ define)
> explicitly in wx_table_generator.hpp and add "= default" definition to
> wx_table_generator.cpp to work around this problem. And then everything
> compiles just fine with both gcc and clang.

I did that too, but...

>  Please let me know if you'd like me to make a PR with these changes or if
> you prefer to do them yourself, as you're working on this code anyhow.

It's better for me to try it myself. But I can't get it to work, so I
put it on an 'odd' branch:

http://git.savannah.nongnu.org/cgit/lmi.git/commit/?h=odd/vector-fwd-decl

What did I do wrong?