lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] [PATCH] Fix columns width in the group premiums PDF


From: Greg Chicares
Subject: Re: [lmi] [PATCH] Fix columns width in the group premiums PDF
Date: Mon, 21 Sep 2015 00:52:36 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0

On 2015-09-20 18:01, Vadim Zeitlin wrote:
> 
>  While reviewing the list of things remaining to do on this sub-project, I
> realized that I've never fixed the bug with the column widths being too
> small for the total amounts that can be displayed in them, so please find
> the patch to do this attached. It's the third patch in this series, the two
> preceding ones are even simpler: the first one

Committed 20150921T0005Z, revision 6293.

> just allows me to compile
> under MSVC without changes (I had it in my local branch before and can go
> on keeping it there if you decide to not apply it, but it would be more
> convenient to not have to do this) and the second one

Committed 20150921T0035Z, revision 6294.

> adjusts the wrong,
> AFAICS, widest value for the "Face Amount" column.

As for the third patch: it took me a while to figure it out. At first
glance, it looked like it didn't do anything. At second glance, it
looked like what it does couldn't solve the problem. But I built and
tested it, and it does solve the problem. Finally, in desperation, I
actually read the documentation in the patch. Thanks for explaining
it so clearly. Committed 20150921T0051Z, revision 6295.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]