[lmi] Better error messages for the GUI test failures

[Vadim Zeitlin]

 Hello,

 Here is the promised patch improving the error messages in case of GUI
test failures. A large(r) part of these changes is actually in wxWidgets
itself and so you need to use 0eca25d395c384fa6ecfaa7120e3be0c129c618a
(r78416) or later for this to work and, actually, with that wxWidgets
version it should already be possible to identify what exactly fails in the
validate_output_illustration test on Kimberley's machine, but the patch
makes it even easier by adding unique descriptive messages to almost all
wxTEST_DIALOG() calls ("almost" because I didn't modify those that will
need to be changed in the near future anyhow).

 E.g. now instead of the original

validate_output_illustration: ERROR (Assertion failure: Expected wxDialog 
dialog was not shown. [file /opt/lmi/local/include/wx-3.1/wx/testing.h, line 
315, in ReportFailure()].)

you should be getting something like this:

validate_output_illustration: ERROR (Assertion failure: Expected illustration 
properties dialog was not shown. [file 
/opt/lmi/src/git/wx_test_validate_output.cpp, line 119, in run()].)

which specifies both the location in the sources where the assert failed,
exactly, and also which dialog was expected.

 Kimberley, could you please let me know what is the new output for the
output validation tests on your machine with these changes, hopefully this
will allow us to diagnose them.

 Thanks in advance!
VZ

0001-Add-descriptions-of-the-expected-modal-dialogs-in-th.patch
Description: Text document