Re: [lmi] [PATCH] Add --gui_test_path command line option to the GUI test.

[Greg Chicares]

On 2014-12-15 13:37, Vadim Zeitlin wrote:
[...default gui test path to "/opt/lmi/gui_test"...]
> Please find attached a patch doing this.

Committed 20141215T1522Z, revision 6080.

> Notice that, as written, running
> the test will generate a warning by default, i.e. if --gui_test_path option
> is not specified and directory /opt/lmi/gui_test doesn't exist. This is not
> very user-friendly but OTOH I am not sure what would be the best thing to
> do if the default directory doesn't exist (I hesitate between creating
> it and just using the current directory silently), and this is not a big
> problem in practice as it's enough to just create that directory to get rid
> of the warning, so for now I chose the simplest solution which is not to do
> anything special.
> 
>  Please let me know if you'd like to see this changed,

I'm thinking of the new developer who downloads the sources, builds the
code, and runs the tests--without any /opt/lmi/gui_test/ directory, and
without the (potentially proprietary) test files it contains. In that case,
I'd like the other tests to run smoothly, without any scary messagebox.
Could you therefore change the messagebox to a reassuring text message on
stdout? Let's say:

<< "Optional extra tests would be run if any were found in '"
<< test_files_path_.native_file_string()
<< ", but no such directory exists. Proceeding to run built-in tests."