Re: [lmi] wx_test_about_version.cpp

[Vadim Zeitlin]

On Sat, 06 Dec 2014 16:07:15 +0000 Greg Chicares <address@hidden> wrote:

GC> Suppose we just open the dialog and make sure it has a scrollbar.
GC> That's good enough for me. Is it easily feasible?

 It's not really simple to verify if the window *shows* a scrollbar. We can
check that it's supposed to show one (e.g. because its virtual height is
greater than its physical height) but it's not clear how useful such a
check is. I think the best we can do is what the attached patch does, i.e.
try to actually scroll the window and verify that it thinks that it has
been scrolled. This still doesn't ensure that it actually did scroll, of
course, the window could be lying to us, but it's the best we can do
without going into OCR and AI realms.

 The rest of the patch implements the remaining points of the specification
taking into account your answers to my earlier questions (thanks!). AFAICS
it is ready to be applied, please let me know if you see anything wrong
with it.

 I will however write another email about --allow-multiple-definition as
this (or rather the mysterious link errors due to its absence) have just
cost me more than an hour to deal with and I'd like to avoid such time
wasting in the future.

 Thanks in advance for the review of this patch,
VZ

0001-Output-the-version-string-shown-in-the-dialog-title.patch
Description: Text document