[lmi] wx update; pending specification changes [Was: Event handling modernization]

[Greg Chicares]

On 2014-12-05 23:12Z, Vadim Zeitlin wrote:
> On Sun, 30 Nov 2014 02:04:56 +0100 I wrote:
> 
> Me>  And to really conclude this topic, I'd like to add that, while debugging
> Me> this, I did find a minor problem related to the help strings: they were 
> not
> Me> shown at all for the items in a popup menu (e.g. the one shown when right
> Me> clicking in a census window). Unfortunately this is something that can't 
> be
> Me> worked around at LMI level, it turned out to be a real bug in wxWidgets 
> and
> Me> I had to fix it there. Nothing is required for this fix to work for LMI:
> Me> when you update to a later revision (I can't give the exact commit as I
> Me> haven't committed it just yet because the wxWidgets svn repository server
> Me> has some problems right now), whether you apply the above patch or not, 
> you
> Me> will just see the help strings in the status bar for the popup menu items
> Me> as well.
> 
>  Just FYI: the above mentioned fix to wxWidgets is committed now and is
> also part of the same git 8ae9dae3b4ae4f1ddeef409d51066263d799e0e2 tree
> already mentioned in my other recent messages.

Okay, I've updated wx, and I see help strings on the statusbar for items
in a popup menu when I right-click on a census window. I also tried this
with an archived lmi-20141016T2306Z, and confirmed that it didn't exhibit
this desirable behavior.

> Me> [...] whether you apply the above patch or not

I'm deliberately deferring it in order to focus on 'wx_test' for now.

I'll also mention a difference I noticed when running 'wx_test' with this
wx update. There's some test that opens the preferences dialog and changes
its fields. It seems "busier" now: my impression is that it cycles through
every combobox item now, whereas previously it just changed the selection
once in each combobox. Of course, it could be that what's happening in the
comboboxes hasn't changed, but the way wx updates the screen has. I'm not
going to spend more time on this now because first I want to review the
specifications for that test, and upon review we may decide that the test
should change.

Kim and I have already reviewed several of the automated GUI tests, and
I'm writing specifications that explain what we really want them to do.
Soon I'll commit a modified 'wx_test_about_version.cpp' with a comment
block indicating the desired behavior. It won't actually describe the code
it precedes, yet; please take is as our request to change the code so that
it does what the comment says.

If that process suits you, I'll commit similar changes to the thirteen
other 'wx_test*.cpp' files. Or, if you prefer, I could copy the comment
block of each file here as we modify it, to start a discussion thread.