lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] Patches for stderr output


From: Vadim Zeitlin
Subject: Re: [lmi] Patches for stderr output
Date: Fri, 5 Dec 2014 22:42:49 +0100

On Fri, 05 Dec 2014 17:42:00 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2014-12-04 21:08Z, Vadim Zeitlin wrote:
GC> > On Thu, 04 Dec 2014 04:43:17 +0000 Greg Chicares <address@hidden> wrote:
GC> [...]
GC> >  In the meanwhile, to finish with this one: I don't actually think writing
GC> > everything to stdout is correct neither. It's arguably more correct than
GC> > writing everything to stderr, but the ideal behaviour would seem to be to
GC> > write the test progress messages to stdout while sending the errors to
GC> > stderr. This can't be done with any standard class such as wxLogStderr but
GC> > it's not difficult to define a custom log target which would do it. Do you
GC> > think it's worth doing this or is the trivial patch above enough?
GC> 
GC> I applied your patch on 20141205T1720Z, revision 6045.

 Thanks!

GC> It's more than enough: it's actually preferable. Normally it would be
GC> better to keep stdout and stderr separate, but in this case we will
GC> never want them separated: we really do want to write all output to
GC> a file, and we're just using the standard stream as an anonymous file.

 OK, I was thinking more about storing stdout to a file and checking that
nothing appears on stderr, but if writing everything to stdout fits your
intended workflow better, this is even better.

GC> Actually, we prefer to use no such prefix ever. So that I can focus
GC> on your other message about logging, could I ask you to propose a
GC> patch to remove the prefix?

 Sure, here it is (attached), please let me know if anything else needs to
be done here.

 Thanks,
VZ

Attachment: 0001-Don-t-use-prefix-for-the-log-messages-generated-by-t.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]