lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi] patch to fix asserts for invalid growable column/row indices with


From: Vadim Zeitlin
Subject: [lmi] patch to fix asserts for invalid growable column/row indices with latest wx svn
Date: Wed, 25 Feb 2009 22:56:35 +0100

 Hello,

 Could you please apply the patch below to skin.xrc to fix many asserts
about invalid growable columns/rows indices use in wx(Flex)GridSizer? This
really complicates the debugging and, besides, even if these invalid
indices are mostly harmless, it still seems wrong to use them. I did my
best to ensure that the patch doesn't change anything and only removes the
invalid indices.

 BTW, is there any reason (other than uniformity?) to use so many trivial
wxFlexGridSizers when a simple wxBoxSizer would do?

 Thanks,
VZ

--- skin.xrc    2009-02-14 22:04:38 +0000
+++ skin.xrc    2009-02-25 21:51:35 +0000
@@ -286,12 +286,12 @@
             <object class="wxFlexGridSizer">
                 <cols>3</cols>
                 <growablecols>1</growablecols>
-                <growablerows>0,1</growablerows>
+                <growablerows>0</growablerows>
                 <object class="sizeritem">
                     <flag>wxGROW|wxALL</flag>
                     <object class="wxFlexGridSizer">
                         <cols>1</cols>
-                        <growablecols>0,1</growablecols>
+                        <growablecols>0</growablecols>
                         <growablerows>0,1</growablerows>
                         <object class="sizeritem">
                             <flag>wxALIGN_LEFT|wxALIGN_TOP|wxALL</flag>
@@ -524,7 +524,7 @@
                     <flag>wxGROW|wxALL</flag>
                     <object class="wxFlexGridSizer">
                         <cols>1</cols>
-                        <growablecols>0,1</growablecols>
+                        <growablecols>0</growablecols>
                         <growablerows>0,1</growablerows>
                         <object class="sizeritem">
                             <object class="wxRadioBox" name="RunOrder">
@@ -1667,7 +1667,7 @@
             <object class="wxFlexGridSizer">
                 <cols>1</cols>
                 <growablecols>0</growablecols>
-                <growablerows>0,1</growablerows>
+                <growablerows>0</growablerows>
                 <object class="sizeritem">
                     <flag>wxGROW|wxALIGN_CENTER_VERTICAL|wxALL</flag>
                     <object class="wxFlexGridSizer">
@@ -1713,13 +1713,13 @@
     <object class="wxFlexGridSizer">
         <rows>1</rows>
         <growablecols>2</growablecols>
-        <growablerows>0,1,2,3</growablerows>
+        <growablerows>0</growablerows>
         <object class="sizeritem">
             <flag>wxGROW|wxALIGN_CENTER_VERTICAL|wxALL</flag>
             <border>4</border>
             <object class="wxFlexGridSizer">
                 <rows>1</rows>
-                <growablecols>0,1</growablecols>
+                <growablecols>0</growablecols>
                 <growablerows>0</growablerows>
                 <object class="sizeritem">
                     <flag>wxGROW|wxALIGN_CENTER_VERTICAL|wxALL</flag>
@@ -1787,7 +1787,7 @@
             <flag>wxGROW|wxALIGN_CENTER_VERTICAL|wxALL</flag>
             <object class="wxFlexGridSizer">
                 <rows>1</rows>
-                <growablecols>0,1,2</growablecols>
+                <growablecols>0</growablecols>
                 <growablerows>0</growablerows>
                 <object class="sizeritem">
                     <flag>wxGROW|wxALL</flag>
@@ -2021,7 +2021,7 @@
                             <border>4</border>
                             <object class="wxFlexGridSizer">
                                 <rows>1</rows>
-                                <growablecols>0,1,2</growablecols>
+                                <growablecols>0</growablecols>
                                 <growablerows>0</growablerows>
                                 <object class="sizeritem">
                                     
<flag>wxGROW|wxALIGN_CENTER_VERTICAL|wxALL</flag>
@@ -2049,7 +2049,7 @@
             <border>4</border>
             <object class="wxFlexGridSizer">
                 <rows>1</rows>
-                <growablecols>0,1,2</growablecols>
+                <growablecols>0</growablecols>
                 <growablerows>0</growablerows>
                 <object class="sizeritem">
                     <flag>wxGROW|wxALIGN_CENTER_VERTICAL|wxALL</flag>
@@ -2064,7 +2064,7 @@
                             <object class="wxFlexGridSizer">
                                 <cols>1</cols>
                                 <growablecols>0</growablecols>
-                                <growablerows>0,1,2,3,4</growablerows>
+                                <growablerows>0</growablerows>
                                 <object class="sizeritem">
                                     
<flag>wxGROW|wxALIGN_CENTER_VERTICAL|wxALL</flag>
                                     <border>4</border>
@@ -2170,7 +2170,7 @@
             <border>4</border>
             <object class="wxFlexGridSizer">
                 <rows>1</rows>
-                <growablecols>0,1,2</growablecols>
+                <growablecols>0,1</growablecols>
                 <growablerows>0</growablerows>
                 <object class="sizeritem">
                     <flag>wxGROW|wxALIGN_CENTER_VERTICAL|wxALL</flag>
@@ -2185,7 +2185,7 @@
                             <object class="wxFlexGridSizer">
                                 <cols>1</cols>
                                 <growablecols>0</growablecols>
-                                <growablerows>0,1,2,3,4</growablerows>
+                                <growablerows>0</growablerows>
                                 <object class="sizeritem">
                                     
<flag>wxGROW|wxALIGN_CENTER_VERTICAL|wxALL</flag>
                                     <border>4</border>
@@ -2665,7 +2665,7 @@
     <object class="wxFlexGridSizer">
         <cols>1</cols>
         <growablecols>0</growablecols>
-        <growablerows>0,1</growablerows>
+        <growablerows>0</growablerows>
         <object class="sizeritem">
             <flag>wxGROW|wxALIGN_CENTER_VERTICAL|wxALL</flag>
             <border>4</border>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]