lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master 76ab8c12 4/7: Eschew magic values


From: Greg Chicares
Subject: [lmi-commits] [lmi] master 76ab8c12 4/7: Eschew magic values
Date: Thu, 23 Jun 2022 18:33:53 -0400 (EDT)

branch: master
commit 76ab8c122e22192d345c6436d4f180ef567eb90c
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Eschew magic values
    
    One of the worst possible magic values is the absence of any value.
    
    - If $(RC) is empty, this must be GNU/Linux.
    + Iff msw, then compile msw resource file.
---
 objects.make   | 2 +-
 posix_fhs.make | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/objects.make b/objects.make
index ddca37e7..e896daa1 100644
--- a/objects.make
+++ b/objects.make
@@ -341,7 +341,7 @@ wx_test_objects := \
   wx_test_pdf_create.o \
   wx_test_validate_output.o \
 
-ifneq (,$(RC))
+ifeq (mingw32,$(findstring mingw32,$(LMI_TRIPLET)))
   lmi_wx_objects  += lmi_msw_res.o
   wx_test_objects += lmi_msw_res.o
 endif
diff --git a/posix_fhs.make b/posix_fhs.make
index f8d984e6..d1b5f4a0 100644
--- a/posix_fhs.make
+++ b/posix_fhs.make
@@ -31,9 +31,7 @@ CC      := gcc
 CPP     := cpp
 CXX     := g++
 LD      := g++
-
-# Don't set RC to anything: elsewhere, this is taken as indicating
-# that msw resources aren't used on this platform.
+# Not used--no value necessary:
 RC      :=
 
 # Programs for which FHS doesn't specify a location.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]