[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master a9bc62f 08/12: Count coding-rules complaints
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master a9bc62f 08/12: Count coding-rules complaints |
Date: |
Mon, 28 Jun 2021 18:44:28 -0400 (EDT) |
branch: master
commit a9bc62f53145686942a6dabf3dfecc8cb62d77f7
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
Count coding-rules complaints
This may or not prove useful someday, but it's so easy to gather a
little more information that there's no reason not to do so.
---
test_coding_rules.cpp | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/test_coding_rules.cpp b/test_coding_rules.cpp
index 7d1e8f6..f2582b1 100644
--- a/test_coding_rules.cpp
+++ b/test_coding_rules.cpp
@@ -41,6 +41,9 @@
#include <stdexcept> // runtime_error
#include <string>
+// Count complaints that are not so severe as to halt processing a file.
+int complaint_count {0};
+
std::string my_taboo_indulgence(); // See 'my_test_coding_rules.cpp'.
std::map<std::string, bool> my_taboos(); // See 'my_test_coding_rules.cpp'.
@@ -259,11 +262,9 @@ bool file::phyloanalyze(std::string const& s) const
return boost::regex_search(file_name(), boost::regex(s));
}
-bool error_flag = false;
-
void complain(file const& f, std::string const& complaint)
{
- error_flag = true;
+ ++complaint_count;
std::cout << "File '" << f.full_name() << "' " << complaint << std::endl;
}
@@ -1277,6 +1278,8 @@ statistics process_file(std::string const& file_path)
int try_main(int argc, char* argv[])
{
+ complaint_count = 0;
+ bool error_flag = false;
statistics z;
for(int j = 1; j < argc; ++j)
{
@@ -1292,5 +1295,5 @@ int try_main(int argc, char* argv[])
}
}
z.print_summary();
- return error_flag ? EXIT_FAILURE : EXIT_SUCCESS;
+ return (error_flag || complaint_count) ? EXIT_FAILURE : EXIT_SUCCESS;
}
- [lmi-commits] [lmi] master d90e9fb 01/12: Ensure that test_coding_rules exits with failure on any error, (continued)
- [lmi-commits] [lmi] master d90e9fb 01/12: Ensure that test_coding_rules exits with failure on any error, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 8882ef7 07/12: Use contains() for the lmi URL check, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 07edbd8 10/12: Document the One True nonempty d-char-sequence, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 4bcdbdb 11/12: Make a test more stringent, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 30ba88a 02/12: Remove check for Latin-9 from coding rules test, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 0f1bc07 03/12: Split the check for canonical header guards in two parts, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master c1edfef 04/12: Use more standard regex syntax in the raw C++11 strings check, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 81c56f8 05/12: Add a test for detecting mis-sorted #include directives, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master 72a9f51 06/12: Add a test for for-range declaration coding style checks, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master b719340 09/12: Reword, Greg Chicares, 2021/06/28
- [lmi-commits] [lmi] master a9bc62f 08/12: Count coding-rules complaints,
Greg Chicares <=
- [lmi-commits] [lmi] master 04ec593 12/12: Make another test more stringent, Greg Chicares, 2021/06/28