lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master 8aa09b9 14/14: Expunge some pointless defect


From: Greg Chicares
Subject: [lmi-commits] [lmi] master 8aa09b9 14/14: Expunge some pointless defect markers [287]
Date: Mon, 5 Apr 2021 18:26:48 -0400 (EDT)

branch: master
commit 8aa09b90ff78001668c6297bc004e18e6f252633
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Expunge some pointless defect markers [287]
    
    It is always possible that other inforce arguments will be needed
    someday; they can be added when and if a need arises.
    
    The C array members are perhaps not ideal, but they are harmless and
    no improvement is necessary. There is nothing to be gained by using
    std::array instead: default special member functions copy C arrays just
    as surely.
    
    One could imagine using arrays with more dimensions, to distinguish
    single vs. level and target vs. excess premiums. However, it is probably
    better to reimplement that part of this class in terms of the more
    modern class gpt_cf_triad in 'gpt_commutation_functions.hpp', whose
    design doesn't need such arrays.
---
 ihs_irc7702.hpp | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/ihs_irc7702.hpp b/ihs_irc7702.hpp
index 8103ca4..11100ad 100644
--- a/ihs_irc7702.hpp
+++ b/ihs_irc7702.hpp
@@ -85,7 +85,6 @@ class Irc7702 final
         ,double                     a_InforceCumGLP
         ,double                     a_InforceGSP
         ,double                     a_InforceCumPremsPaid
-        // TODO ?? TAXATION !! Perhaps other arguments are needed for inforce.
         );
 
     void Initialize7702
@@ -218,7 +217,6 @@ class Irc7702 final
     double                     CumPmts;    // Cumulative payments
 
     // Commutation functions
-// TODO ?? TAXATION !! Consider using std::vector instead of array members.
     ULCommFns CommFns                          [NumIOBases];
     double                     DEndt           [NumIOBases];
 
@@ -233,7 +231,6 @@ class Irc7702 final
     std::vector<double>        PvChgSpecAmt    [NumIOBases];
     std::vector<double>        PvChgADD        [NumIOBases];
     std::vector<double>        PvChgMort       [NumIOBases];
-    // TODO ?? TAXATION !! Perhaps -Sgl/Lvl and -Tgt/Exc should be dimensions.
     std::vector<double>        PvNpfSglTgt     [NumIOBases];
     std::vector<double>        PvNpfLvlTgt     [NumIOBases];
     std::vector<double>        PvNpfSglExc     [NumIOBases];



reply via email to

[Prev in Thread] Current Thread [Next in Thread]